Skip to content

fix(dashboards): prevent sticky navbar misalignment on scroll#115716

Merged
priscilawebdev merged 1 commit into
masterfrom
priscila/fix/dashboard-navbar-scroll-misalignment
May 18, 2026
Merged

fix(dashboards): prevent sticky navbar misalignment on scroll#115716
priscilawebdev merged 1 commit into
masterfrom
priscila/fix/dashboard-navbar-scroll-misalignment

Conversation

@priscilawebdev
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev commented May 18, 2026

Before

image

After

image

The GridLayout's `margin: -xl` (-16px) over-cancelled the new pageframe
Layout.Body vertical padding of `lg` (12px), causing 4px of vertical
overflow. That overflow extended document.scrollHeight past the sticky
navbar's containing block, so scrolling to the bottom of a dashboard
pulled the navbar a few pixels up — visibly misaligning it with the
TopBar.

Use `-lg -xl` so the vertical magnitude matches the pageframe Body
padding and the grid no longer overflows.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.53%

@priscilawebdev priscilawebdev marked this pull request as ready for review May 18, 2026 11:36
@priscilawebdev priscilawebdev requested a review from a team as a code owner May 18, 2026 11:36
@priscilawebdev priscilawebdev enabled auto-merge (squash) May 18, 2026 11:36
@priscilawebdev priscilawebdev requested review from a team May 18, 2026 11:40
Copy link
Copy Markdown
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@priscilawebdev priscilawebdev merged commit fbb2315 into master May 18, 2026
76 checks passed
@priscilawebdev priscilawebdev deleted the priscila/fix/dashboard-navbar-scroll-misalignment branch May 18, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants