fix(preprod): Skip strict jsonschema for snapshot image metadata#115720
Merged
Conversation
Sidecar JSON files can contain boolean or numeric values in tags (e.g., "show_background": true). The JSON Schema was rejecting these with "True is not of type 'string'". Relax the tags JSON Schema to accept any object (not just string values), and coerce all tag values to strings in the Pydantic validator so downstream code sees a consistent dict[str, str]. EME-1156
Let Pydantic handle image metadata validation instead of rejecting requests upfront with jsonschema. Sidecar JSON files can contain any types, and Pydantic already coerces values appropriately. The jsonschema still validates the top-level structure (app_id, VCS fields, etc.). Pydantic ValidationError is caught and returned as a 400 instead of becoming a 500. EME-1156
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
rbro112
approved these changes
May 18, 2026
NicoHinderling
approved these changes
May 18, 2026
Move Pydantic SnapshotManifest validation before the atomic block so that a ValidationError returns 400 without committing orphaned PreprodArtifact and PreprodSnapshotMetrics rows.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f65e84. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageMetadata.schema()from the jsonschema validation for image entries — replaces withadditionalProperties: TrueSnapshotManifest, which already coerces types and allows extra fieldspydantic.ValidationErrorand returns a 400 with a useful message instead of letting it become a 500Depends on #115710
Fixes EME-1156