fix(alerts): Batch NotificationMessage delete metric alert rows#115726
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
wedamija
approved these changes
May 18, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4dca709. Configure here.
| row.delete() | ||
| while True: | ||
| ids = list( | ||
| NotificationMessage.objects.filter(action__isnull=True).values_list("id", flat=True)[ |
Contributor
There was a problem hiding this comment.
Filter criteria changed, may delete unintended rows
High Severity
The filter changed from incident__isnull=False, trigger_action__isnull=False (specifically metric alert rows) to action__isnull=True (any row without a workflow action). Despite the function being named delete_old_rows_metric_alerts, the new filter is strictly broader — it matches all rows lacking an action, including any orphaned rows where incident and trigger_action are also null. The PR description says this is just a batching change, but the filter criteria silently changed too, which could cause unintended data deletion.
Reviewed by Cursor Bugbot for commit 4dca709. Configure here.
Contributor
Backend Test FailuresFailures on
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch the deletion here because the table is so large it ran for 12 hours and timed out.