perf(bootstrap): Parallelize locale and moment chunk fetches#115727
Merged
Conversation
For non-English users, the translation .po file and the moment locale chunk were fetched sequentially. These are independent network requests, so fetch them in parallel with Promise.all to remove one waterfall from the boot path. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Catch errors from moment locale imports to ensure setLocale is always called with translations, even if the moment locale doesn't exist. This prevents non-English users from losing all translations when their moment locale fails to load. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f1ee54. Configure here.
Use explicit .then() and .catch() handlers on the entire Promise.all chain to guard against any errors. This ensures setLocale is always called - either with translations on success, or with DEFAULT_LOCALE_DATA on failure. Also adds DEFAULT_LOCALE_DATA fallback in the outer catch block to prevent app initialization failure. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
natemoo-re
approved these changes
May 18, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
LGTM! Not blocking but I don't think we need both fallbacks?
The moment locale import rejection was propagating through Promise.all, causing successfully fetched translations to be discarded in the catch handler. Handle the moment import failure independently so setLocale is always called with the correct translations. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallelize translation async resources for non english users (we don't need to fetch them sequentially)