fix(ourlogs): reset column sort to default on third click#115751
Merged
Conversation
Column sort previously cycled between desc and asc with no way to return to the default sort. Add a third state: clicking an already-asc column resets the infinite table to timestamp-desc (the default) and the aggregate table to its first-field-desc default. Fixes LOGS-808 Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.55% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 683a36e. Configure here.
nsdeschenes
approved these changes
May 19, 2026
Contributor
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
Looks good, one small stylistic nit 🎨
Member
Author
|
Oh @nsdeschenes I found a bug, let me fix and then un-draft... |
Member
Author
|
Never mind, I was working in the wrong directory locally. 🤦 |
nsdeschenes
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Column sort previously had no way to return to the default state: clicking a column header only toggled between
descandasc. This adds a third state to reset back to default.undefined → desc → asc → timestamp desc(the default sort)undefined → desc → asc → first-field desc(the aggregate default)Closes LOGS-808.