ref: Remove browserHistory by inlining navigate in upgradeNowModal callers#115755
Merged
ryan953 merged 2 commits intoMay 18, 2026
Merged
Conversation
Change redirectToManage to accept a navigate function parameter instead of importing browserHistory directly. All callers are React components and now pass useNavigate() from React Router 6. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.55% |
Remove the redirectToManage utility entirely. Each call site now uses navigate() directly with a unique referrer string that identifies the specific error context, rather than sharing a single generic referrer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ryan953
changed the title
ryan953
deleted the
ryan953/ref/remove-browserhistory-from-upgradenowmodal-utils
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
redirectToManageutility and itsbrowserHistorydependency entirely. Each call site now usesuseNavigate()directly with a unique referrer string that identifies the specific error context (e.g.profiling_upgrade_modal-update_plan-error), rather than sharing a single generic referrer. DeletesupgradeNowModal/utils.tsx.Refs https://github.com/getsentry/frontend-tsc/issues/78