ref(aci): Minor cleanup to delayed workflow processing#115758
Merged
Conversation
…educe tracking / debug logs -- turns out this is about 50% of the calls to fire_actions_for_groups.
github-actions
Bot
added
the
Scope: Backend
saponifi3d
commented
May 18, 2026
| ) | ||
|
|
||
| fire_actions_for_groups(project.organization, groups_to_dcgs, group_to_groupevent) | ||
| if groups_to_dcgs and group_to_groupevent: |
Contributor
Author
There was a problem hiding this comment.
this should be a noop since it's already handled internally, but this will remove all the .info logs and the timing information when there isn't anything to fire.
ceorourke
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fire_actions_for_groupsif there are actions to trigger; approx 50% of the calls to this method there aren't groups_to_dcgs or group_to_group_event.