feat(options): Add timing metric to options.get()

[kenzoengineer]

make sure to remove whitespace from the diff to view the real changes (minimal)

Wraps the OptionsManager.get() to establish baseline performance of the current sentry options system. We will compare this to the new sentry options system to ensure we don't regress. Also includes some tests to ensure the metrics function is being called.

This matches the pattern already used with features.has() (see src/sentry/features/manager.py line 280)

Assuming our metrics library is written well, there should be minimal overhead. We set the sample rate low (1%) to reduce metrics volume.

[linear-code]

DI-1937

[kenzoengineer]

When we import metrics, we try to access settings.SENTRY_METRICS_SKIP_ALL_INTERNAL. If we move this import to the top, we do this before django is configured (and thus, django settings), causing a crash.

[kenzoengineer]

see line 23 of src/sentry/utils/metrics.py

[kenzoengineer]

(this is because options/manager.py is imported before django is configured in case that isn't clear).

moving the import down here means it'll only be imported when the application makes the call, long after we set up django

[shashjar]

thanks for specifying 🙏

[markstory]

There isn't a system.region option/value. Perhaps you want to use settings.SENTRY_LOCAL_CELL instead? That setting will give you the cell/region name but will be None in control + single-tenants. To capture all of those deployment modes is more complex :(.

sentry_env = os.environ.get("CUSTOMER_ID", settings.SENTRY_LOCAL_CELL) or "unknown"
if SiloMode.get_current_mode() == SiloMode.CONTROL:
  sentry_env = SiloMode.CONTROL.name

[kenzoengineer]

ahh thank you i missed this, I'm ok with having this block of code if it means I have metrics per region

[sentry]

Bug: The region metric tag incorrectly prioritizes the CUSTOMER_ID environment variable over SENTRY_LOCAL_CELL (SENTRY_REGION), leading to incorrect region tagging in metrics.
_{Severity: MEDIUM}

Suggested Fix

Reverse the order of lookups for the region tag. Prioritize settings.SENTRY_LOCAL_CELL and use os.environ.get("CUSTOMER_ID") as the fallback, following the existing pattern in the codebase.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/sentry/options/manager.py#L299

Potential issue: The logic for determining the `region` metric tag is inverted. It
checks the `CUSTOMER_ID` environment variable before `settings.SENTRY_LOCAL_CELL` (which
is derived from `SENTRY_REGION`). In production environments where both variables are
set, such as Sentry's own deployment, the `region` tag will be incorrectly populated
with a customer ID (e.g., "sentry4sentry") instead of the actual region name. This will
render region-based analysis of timing metrics inaccurate. The established pattern in
the codebase is to check for the region first.

[markstory]

CUSTOMER_ID and LOCAL_CELL are mutually exclusive when we configure environments.