fix(tests): Ensure ThemeFixture returns valid theme object for ThemeProvider#115781
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(tests): Ensure ThemeFixture returns valid theme object for ThemeProvider#115781sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Invalid value used as weak map keyoccurring in test environments, specifically withincustomRenderinreactTestingLibrary.tsx.Problem:
The error originated from
@emotion/weak-memoize(used by@emotion/react'sThemeProvider) when thethemeprop passed toThemeProviderwas not a valid object. This became a critical issue after the React 19 / Emotion 11.14 upgrade, asweak-memoizebecame stricter, throwing an error for non-object WeakMap keys (e.g.,undefinedor primitives).In our test setup,
customRenderuses<ThemeProvider theme={ThemeFixture()}>. TheThemeFixture()function was returninglightThemewhich, under certain module resolution timings or circular import scenarios, could resolve toundefinedor a non-object value at the point it was used byThemeProvider.Solution:
tests/js/fixtures/theme.tsx: ModifiedThemeFixtureto include a runtime check. It now explicitly verifies thatlightThemeis a non-null object. If not, it throws a more descriptive error, preventing the opaqueWeakMaperror. It also returns a spread copy ({...lightTheme}) to ensure a fresh, plain object is always provided, preventing accidental mutations and ensuring compatibility withweak-memoize.tests/js/sentry-test/reactTestingLibrary.tsx: IncustomRender, the result ofThemeFixture()is now explicitly stored in athemevariable and validated to be a non-null object before being passed to<ThemeProvider>. This adds an additional layer of safety and provides an earlier, clearer error message ifThemeFixturesomehow returns an invalid value.These changes ensure that
ThemeProvideralways receives a valid object as itsthemeprop in tests, resolving theTypeErrorand making the test harness more robust against theme resolution issues.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JEST-2KVF