fix(crons): De-flake "prefills with an existing monitor" test#115782
Merged
priscilawebdev merged 1 commit intoMay 19, 2026
Merged
Conversation
The test re-clicked the already-checked Crontab and Los Angeles
menuitemradios after asserting `toBeChecked()`. Each click dispatched a
same-value `setValue` into the FormModel, which still runs
`validateField` and `updateShowSaveState` and schedules a re-render.
That extra state churn was the source of the rare race where the Grace
Period spinbutton briefly displayed `55` instead of `5` before the
assertion ran.
Close the menus with `{Escape}` instead — the same pattern this test
already uses for Owner and Notify a few lines below. Drop the
`it.isKnownFlake` wrapper now that the source of the race is gone.
Fixes JEST-22P6
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
TkDodo
approved these changes
May 19, 2026
priscilawebdev
deleted the
priscilawebdev/fix/jest-22p6-tests-fix-flaky-monitorform-prefills-test
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De-flake the
prefills with an existing monitortest inmonitorForm.spec.tsx.After asserting
toBeChecked()on the Crontab and Los Angelesmenuitemradiooptions, the test re-clicked them. Each click dispatched a same-valuesetValueinto the FormModel, which still ranvalidateFieldandupdateShowSaveStateand scheduled a re-render. That extra state churn was the source of the rare race where the Grace Period spinbutton briefly read55instead of5before the next assertion ran (JEST-22P6 in Sentry).Close the menus with
{Escape}instead — the same pattern this test already uses for Owner and Notify a few lines below — and remove theit.isKnownFlakewrapper now that the source of the race is gone.Verified locally: 25/25 consecutive isolated runs of this test pass, and the full spec file passes (5/5).
Fixes JEST-22P6