Skip to content

test(spans): Add isolated load segment data coverage#115804

Merged
lvthanh03 merged 3 commits into
masterfrom
tony/unit-tests-load-segment-data
May 19, 2026
Merged

test(spans): Add isolated load segment data coverage#115804
lvthanh03 merged 3 commits into
masterfrom
tony/unit-tests-load-segment-data

Conversation

@lvthanh03
Copy link
Copy Markdown
Member

@lvthanh03 lvthanh03 commented May 19, 2026

Refs STREAM-998

Add focused test coverage for SpansBuffer._load_segment_data before refactoring the span buffer.

The new tests executes _load_segment_data directly with a small Redis test double, covering distributed payload keys, paginated SSCAN, zstd batch decompression, dropped-span outcome tracking, and expired empty-segment metrics.

@lvthanh03 lvthanh03 requested review from a team as code owners May 19, 2026 15:15
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4a794e2. Configure here.

Comment thread tests/sentry/spans/test_buffer.py Outdated
Comment thread tests/sentry/spans/test_buffer.py Outdated
@lvthanh03 lvthanh03 merged commit 04309fb into master May 19, 2026
55 checks passed
@lvthanh03 lvthanh03 deleted the tony/unit-tests-load-segment-data branch May 19, 2026 16:33
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 19, 2026

STREAM-998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants