ref(compactSelect): remove unused onSectionToggle callback#115809
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2968284. Configure here.
JonasBa
approved these changes
May 19, 2026
Member
JonasBa
left a comment
JonasBa
left a comment
There was a problem hiding this comment.
I'm a simple man... I see deleted code, I approve
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
There are places where we use the `showToggleAll` feature, which shows a `toggleAll` button. This button used to have a dedicated extra callback `onSectionToggle`, which is unused. Clicking Toggle All will just trigger individual change events, which is what consumers listen to.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are places where we use the
showToggleAllfeature, which shows atoggleAllbutton. This button used to have a dedicated extra callbackonSectionToggle, which is unused.Clicking Toggle All will just trigger individual change events, which is what consumers listen to.