ref(settings): update `action` prop and remove `hasPageFrame` by natemoo-re · Pull Request #115815 · getsentry/sentry

natemoo-re · 2026-05-19T16:54:29Z

Apologies for the big cleanup PR, but it was a bunch of interconnected changes that were hard to break up.

Settings pages projected page-level action buttons into the TopBar via SettingsPageHeader.action → TopBar.Slot name="actions". The TopBar should only contain search, Ask Seer, and feedback. This PR removes that projection, cleans up the fully-rolled-out hasPageFrame feature flag, and aligns billing/usage layouts.

TopBar & SettingsSearch

New search slot on TopBar; SettingsSearch moves from actions → search

SettingsPageHeader

Remove legacy non-page-frame rendering path, noTitleStyles, className props
Repurpose action prop: renders inline next to subtitle instead of projecting into TopBar
Subtitle gets a default max-width: 72ch for readability
Consumers pass subtitle + action as props, no Flex boilerplate

hasPageFrame cleanup

Remove useHasPageFrameFeature() from settings infrastructure and ~40 page components
Delete orphaned organizationRegionAction.tsx and unused settingsHeader.tsx
Last breadcrumb segment renders as <span> (not a link), matching page-frame design

Inline actions

Pages with standalone action buttons (Dynamic Sampling, Console SDK Invites, Seer Autofix/Code Review, Repositories, API Tokens, Org Auth Tokens, Client Keys, Relay, User Feedback) now use the action prop directly
Pages with custom feedback buttons use <TopBar.Slot name="feedback"> instead

Billing/Usage layouts

Align SubscriptionSettingsLayout with SettingsLayout: remove dead hasPageFrame ternary, switch to search TopBar slot, add background="primary"
Clean up SubscriptionPageContainer to hardcode page-frame path
Remove background="secondary" prop from SubscriptionPageContainer callers

Spacing

Settings layout top padding normalized: md (8px) → xl (16px)
Remove redundant padding-top on Subtitle component

github-actions · 2026-05-19T16:57:54Z

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.60%

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 15dc8b1. Configure here.}

sentry · 2026-05-20T20:48:27Z

+    <Fragment>
+      {typeof title === 'string' ? (
+        <BreadcrumbTitle routes={routes} title={title} />
+      ) : (
+        title && <Layout.Title>{title}</Layout.Title>


Bug: SettingsPageHeader now uses BreadcrumbTitle which renders null outside a BreadcrumbProvider, causing the title on the 'Accept organization invite' page to disappear.
_{Severity: HIGH}

Suggested Fix

In SettingsPageHeader, add a check for the BreadcrumbContext. If the context is not available, fall back to rendering the title using a component that does not depend on it, such as the previous <Layout.Title>{title}</Layout.Title>. This will restore the title on pages like acceptOrganizationInvite that are rendered outside the main settings layout.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: static/app/views/settings/components/settingsPageHeader.tsx#L22-L26 Potential issue: The `SettingsPageHeader` component was changed to unconditionally use `BreadcrumbTitle` for string titles. However, `BreadcrumbTitle` is a no-op and renders `null` when not used within a `BreadcrumbProvider` context. The `acceptOrganizationInvite` page is rendered outside any settings layout that provides this context, as it's part of an unauthenticated flow with no organization context. As a result, the page title, `t('Accept organization invite')`, is no longer displayed to users visiting the organization invite acceptance page, leaving the page without a heading.

Also affects:

static/app/views/acceptOrganizationInvite/index.tsx

_{Did we get this right? 👍 / 👎 to inform future reviews.}

JonasBa

The changes look good - I've went and reviewed the preview deployment and checked the pages, and everything looks good. Great cleanup @natemoo-re 🫶

JonasBa · 2026-05-21T14:53:02Z

 } from './constants';

-const Slot = slot(['title', 'actions', 'feedback'] as const);
+const Slot = slot(['title', 'search', 'actions', 'feedback'] as const);


Great idea to extend the topbar with a search slot 👍🏼

…sPageFrame from settings infrastructure Add a dedicated 'search' slot to TopBar for SettingsSearch, replacing its use of the 'actions' slot. Remove the action prop from SettingsPageHeader entirely — it was projecting page-level actions into the TopBar, which should only contain search, Ask Seer, and feedback. Strip all hasPageFrame feature-flag checks from settings infrastructure components (SettingsPageHeader, SettingsLayout, SettingsHeader, SettingsWrapper, SettingsBreadcrumb) since the flag is now always true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

More tests that relied on SettingsPageHeader rendering visible heading text. Also fixes breadcrumb test (last crumb is now a span, not a link) and moves key-details test-id to a wrapper div so acceptance tests can find it.

Move key-details data-test-id to wrapper div with proper indentation. Fix projectKeys details test to use test-id instead of heading text. Fix audit log test to use visible page content.

Bump desktop top padding from md (8px) to xl (16px) so descriptions and alerts below the TopBar have more breathing room.

…ng and console SDK invites

…itories pages

Remove hasPageFrame dead code from SubscriptionSettingsLayout and SubscriptionPageContainer. Use search TopBar slot instead of actions. Normalize default padding to xl to match other settings pages.

… rendering SettingsPageHeader now renders action inline next to subtitle in a Flex layout, replacing the boilerplate each consumer repeated. This simplifies 10 files that previously wrapped subtitle+action in Flex.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ernal Flex wrappers Move actions back into the `action` prop where the remove/restore roundtrip left them rendered outside the component. Fix subtitle+action Flex alignment from `center` to `start` for multiline subtitles, and drop the no-op `padding: 0` on Subtitle.

…r callers Callers were passing background="secondary" which overrode the hardcoded background="primary" in SubscriptionPageContainer via the ...rest spread, preventing the white page background from rendering. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>

Constrain subtitle text to 72ch for better readability, regardless of whether page-level actions are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…es (#116013) Follow-up to #115815. That PR removed the `hasPageFrame` branch from `SettingsPageHeader`, making it unconditionally render `BreadcrumbTitle` for string titles. `BreadcrumbTitle` returns `null` and only updates breadcrumb context as a side effect — but the accept-invite and accept-transfer pages are routed outside `SettingsWrapper`, so there's no `BreadcrumbProvider` ancestor. The page headings silently disappeared. These pages aren't settings pages, so they shouldn't use `SettingsPageHeader` at all. Replaced with `Layout.Title` directly.

Apologies for the big cleanup PR, but it was a bunch of interconnected changes that were hard to break up. Settings pages projected page-level action buttons into the TopBar via `SettingsPageHeader.action` → `TopBar.Slot name="actions"`. The TopBar should only contain search, Ask Seer, and feedback. This PR removes that projection, cleans up the fully-rolled-out `hasPageFrame` feature flag, and aligns billing/usage layouts. **TopBar & SettingsSearch** - New `search` slot on TopBar; `SettingsSearch` moves from `actions` → `search` **SettingsPageHeader** - Remove legacy non-page-frame rendering path, `noTitleStyles`, `className` props - Repurpose `action` prop: renders inline next to subtitle instead of projecting into TopBar - Subtitle gets a default `max-width: 72ch` for readability - Consumers pass `subtitle` + `action` as props, no Flex boilerplate **`hasPageFrame` cleanup** - Remove `useHasPageFrameFeature()` from settings infrastructure and ~40 page components - Delete orphaned `organizationRegionAction.tsx` and unused `settingsHeader.tsx` - Last breadcrumb segment renders as `<span>` (not a link), matching page-frame design **Inline actions** - Pages with standalone action buttons (Dynamic Sampling, Console SDK Invites, Seer Autofix/Code Review, Repositories, API Tokens, Org Auth Tokens, Client Keys, Relay, User Feedback) now use the `action` prop directly - Pages with custom feedback buttons use `<TopBar.Slot name="feedback">` instead **Billing/Usage layouts** - Align `SubscriptionSettingsLayout` with `SettingsLayout`: remove dead `hasPageFrame` ternary, switch to `search` TopBar slot, add `background="primary"` - Clean up `SubscriptionPageContainer` to hardcode page-frame path - Remove `background="secondary"` prop from `SubscriptionPageContainer` callers **Spacing** - Settings layout top padding normalized: `md` (8px) → `xl` (16px) - Remove redundant `padding-top` on `Subtitle` component --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

…es (#116013) Follow-up to #115815. That PR removed the `hasPageFrame` branch from `SettingsPageHeader`, making it unconditionally render `BreadcrumbTitle` for string titles. `BreadcrumbTitle` returns `null` and only updates breadcrumb context as a side effect — but the accept-invite and accept-transfer pages are routed outside `SettingsWrapper`, so there's no `BreadcrumbProvider` ancestor. The page headings silently disappeared. These pages aren't settings pages, so they shouldn't use `SettingsPageHeader` at all. Replaced with `Layout.Title` directly.

Apologies for the big cleanup PR, but it was a bunch of interconnected changes that were hard to break up. Settings pages projected page-level action buttons into the TopBar via `SettingsPageHeader.action` → `TopBar.Slot name="actions"`. The TopBar should only contain search, Ask Seer, and feedback. This PR removes that projection, cleans up the fully-rolled-out `hasPageFrame` feature flag, and aligns billing/usage layouts. **TopBar & SettingsSearch** - New `search` slot on TopBar; `SettingsSearch` moves from `actions` → `search` **SettingsPageHeader** - Remove legacy non-page-frame rendering path, `noTitleStyles`, `className` props - Repurpose `action` prop: renders inline next to subtitle instead of projecting into TopBar - Subtitle gets a default `max-width: 72ch` for readability - Consumers pass `subtitle` + `action` as props, no Flex boilerplate **`hasPageFrame` cleanup** - Remove `useHasPageFrameFeature()` from settings infrastructure and ~40 page components - Delete orphaned `organizationRegionAction.tsx` and unused `settingsHeader.tsx` - Last breadcrumb segment renders as `<span>` (not a link), matching page-frame design **Inline actions** - Pages with standalone action buttons (Dynamic Sampling, Console SDK Invites, Seer Autofix/Code Review, Repositories, API Tokens, Org Auth Tokens, Client Keys, Relay, User Feedback) now use the `action` prop directly - Pages with custom feedback buttons use `<TopBar.Slot name="feedback">` instead **Billing/Usage layouts** - Align `SubscriptionSettingsLayout` with `SettingsLayout`: remove dead `hasPageFrame` ternary, switch to `search` TopBar slot, add `background="primary"` - Clean up `SubscriptionPageContainer` to hardcode page-frame path - Remove `background="secondary"` prop from `SubscriptionPageContainer` callers **Spacing** - Settings layout top padding normalized: `md` (8px) → `xl` (16px) - Remove redundant `padding-top` on `Subtitle` component --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

…es (#116013) Follow-up to #115815. That PR removed the `hasPageFrame` branch from `SettingsPageHeader`, making it unconditionally render `BreadcrumbTitle` for string titles. `BreadcrumbTitle` returns `null` and only updates breadcrumb context as a side effect — but the accept-invite and accept-transfer pages are routed outside `SettingsWrapper`, so there's no `BreadcrumbProvider` ancestor. The page headings silently disappeared. These pages aren't settings pages, so they shouldn't use `SettingsPageHeader` at all. Replaced with `Layout.Title` directly.

github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 19, 2026

vercel Bot deployed to Preview May 19, 2026 21:06 View deployment

vercel Bot deployed to Preview May 20, 2026 16:09 View deployment

vercel Bot deployed to Preview May 20, 2026 16:25 View deployment

vercel Bot deployed to Preview May 20, 2026 16:40 View deployment

vercel Bot deployed to Preview May 20, 2026 16:58 View deployment

vercel Bot deployed to Preview May 20, 2026 18:26 View deployment

vercel Bot deployed to Preview May 20, 2026 18:31 View deployment

vercel Bot deployed to Preview May 20, 2026 18:37 View deployment

vercel Bot deployed to Preview May 20, 2026 18:40 View deployment

vercel Bot deployed to Preview May 20, 2026 18:44 View deployment

vercel Bot deployed to Preview May 20, 2026 19:02 View deployment

vercel Bot deployed to Preview May 20, 2026 19:08 View deployment

vercel Bot deployed to Preview May 20, 2026 19:15 View deployment

vercel Bot deployed to Preview May 20, 2026 19:20 View deployment

vercel Bot deployed to Preview May 20, 2026 19:25 View deployment

vercel Bot deployed to Preview May 20, 2026 19:59 View deployment

vercel Bot deployed to Preview May 20, 2026 20:27 View deployment

vercel Bot deployed to Preview May 20, 2026 20:41 View deployment

natemoo-re marked this pull request as ready for review May 20, 2026 20:42

natemoo-re requested review from a team as code owners May 20, 2026 20:42

cursor Bot reviewed May 20, 2026

View reviewed changes

Comment thread static/app/views/settings/components/settingsPageHeader.tsx

natemoo-re changed the title ~~ref(page-frame): remove action prop and hasPageFrame from settings pages~~ ref(settings): update action prop and hasPageFrame May 20, 2026

natemoo-re changed the title ~~ref(settings): update action prop and hasPageFrame~~ ref(settings): update action prop and remove hasPageFrame May 20, 2026

sentry Bot reviewed May 20, 2026

View reviewed changes

JonasBa approved these changes May 21, 2026

View reviewed changes

natemoo-re and others added 17 commits May 21, 2026 11:00

fix(page-frame): fix key-details test-id, audit log, and formatting

f7cd6e4

Move key-details data-test-id to wrapper div with proper indentation. Fix projectKeys details test to use test-id instead of heading text. Fix audit log test to use visible page content.

chore(page-frame): apply oxfmt formatting

7b1d9bb

ref(page-frame): increase top padding in settings layout

686ae2a

Bump desktop top padding from md (8px) to xl (16px) so descriptions and alerts below the TopBar have more breathing room.

fix(page-frame): remove subtitle top padding that doubled with layout

29da624

ref(page-frame): simplify settings layout padding shorthand

3f7f9a7

ref(page-frame): move actions inline with subtitle for dynamic sampli…

6b4d7e1

…ng and console SDK invites

ref(page-frame): move actions inline with subtitle for seer and repos…

74a94f6

…itories pages

ref(page-frame): align subscription settings layout with SettingsLayout

adfed84

Remove hasPageFrame dead code from SubscriptionSettingsLayout and SubscriptionPageContainer. Use search TopBar slot instead of actions. Normalize default padding to xl to match other settings pages.

ref(page-frame): remove unused settingsHeader component

cc4bfb5

ref(page-frame): add primary background to subscription settings layout

f4263eb

fix: remove unused Flex import in subscriptionSettingsLayout

36d504b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chore: format projectUserFeedback

f3973db

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ref(page-frame): Set default max-width on SettingsPageHeader subtitle

e7bdb99

Constrain subtitle text to 72ch for better readability, regardless of whether page-level actions are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

natemoo-re force-pushed the nm/page-frame/settings-actions branch from 15dc8b1 to e7bdb99 Compare May 21, 2026 15:05

vercel Bot deployed to Preview May 21, 2026 15:06 View deployment

Merge branch 'master' into nm/page-frame/settings-actions

2873053

vercel Bot deployed to Preview May 21, 2026 15:25 View deployment

natemoo-re merged commit e773d88 into master May 21, 2026
70 checks passed

natemoo-re deleted the nm/page-frame/settings-actions branch May 21, 2026 15:32

natemoo-re mentioned this pull request May 21, 2026

fix(settings): restore title on accept-invite and accept-transfer pages #116013

Merged

sentry-release-bot Bot mentioned this pull request May 27, 2026

publish: getsentry/sentry@26.5.1 getsentry/publish#8288

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(settings): update `action` prop and remove `hasPageFrame`#115815

ref(settings): update `action` prop and remove `hasPageFrame`#115815
natemoo-re merged 24 commits into
masterfrom
nm/page-frame/settings-actions

natemoo-re commented May 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 19, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

sentry Bot May 20, 2026

Uh oh!

JonasBa left a comment

Uh oh!

JonasBa May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

natemoo-re commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Type Coverage Diff

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sentry Bot May 20, 2026

Choose a reason for hiding this comment

Uh oh!

JonasBa left a comment

Choose a reason for hiding this comment

Uh oh!

JonasBa May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

natemoo-re commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading