chore(alerts): Add index on date_added, soft remove metric alert colu…#115823
Merged
ceorourke merged 3 commits intoMay 20, 2026
Conversation
…mns on NotificationMessage
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Moved notificationmessage.incident field to pending deletion state
--
-- (no-op)
--
-- Moved notificationmessage.trigger_action field to pending deletion state
--
-- (no-op)
--
-- Create index sentry_noti_date_ad_ac82c5_idx on field(s) date_added of model notificationmessage
--
CREATE INDEX CONCURRENTLY "sentry_noti_date_ad_ac82c5_idx" ON "sentry_notificationmessage" ("date_added"); |
wedamija
approved these changes
May 19, 2026
Member
wedamija
left a comment
There was a problem hiding this comment.
lgtm, this will need to be post deploy though since the index will take a while.
The soft removals are a no-op so it'll be fine to have them run as part of the post deploy
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #115578 to start removal of the metric alert columns and add an index on
date_addedto prep for adding a cleanup job on the table for rows over 90 days old.