Skip to content

ref(cells): Remove the includeFeatureFlags query param from the org listing request#115833

Merged
lynnagara merged 1 commit into
masterfrom
org-list-include-feature-flag
May 20, 2026
Merged

ref(cells): Remove the includeFeatureFlags query param from the org listing request#115833
lynnagara merged 1 commit into
masterfrom
org-list-include-feature-flag

Conversation

@lynnagara
Copy link
Copy Markdown
Member

This removes the includeFeatureFlags query param from being sent with the org listing request when linking an organization to integration.

This change is a no-op:

  • the features property is never read anywhere in the UI code
  • the org listing API won't be able to return features as it's moving to control

…isting call

This removes the includeFeatureFlags query param from being sent with the
org listing request when linking an organization.

- the `features` property is never read anyway
- the org listing API won't be able to return features as it's moving to control
@lynnagara lynnagara requested a review from a team May 19, 2026 18:48
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.56%

[getApiUrl('/organizations/'), {query: {include_feature_flags: 1}}],
{staleTime: Infinity}
);
} = useApiQuery<Organization[]>([getApiUrl('/organizations/')], {staleTime: Infinity});
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Organization become OrganizationSummary here so that we can use typescript to validate that we aren't using fields that won't be available on the response data?

Copy link
Copy Markdown
Member Author

@lynnagara lynnagara May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah definitely.. though i think gets threaded through into a bunch of places not just here. I'll open a separate PR to update all the types once the dependencies for that are met.

Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The org list data is just used to do counts + make select options so feature flags aren't used.

@lynnagara lynnagara merged commit 2ec9876 into master May 20, 2026
72 checks passed
@lynnagara lynnagara deleted the org-list-include-feature-flag branch May 20, 2026 18:09
JonasBa pushed a commit that referenced this pull request May 21, 2026
…isting request (#115833)

This removes the includeFeatureFlags query param from being sent with
the org listing request when linking an organization to integration.

This change is a no-op:
- the `features` property is never read anywhere in the UI code
- the org listing API won't be able to return features as it's moving to
control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants