ref(preprod): Use TimeToIdle instead of TimeToLive for upload expiration#115837
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 19c2247. Configure here.
NicoHinderling
commented
May 19, 2026
| _OBJECTSTORE_CLIENT: Client | None = None | ||
| _ATTACHMENTS_USECASE: Usecase | None = None | ||
| _PREPROD_USECASE = Usecase("preprod", expiration_policy=TimeToLive(timedelta(days=30))) | ||
| _PREPROD_USECASE = Usecase("preprod", expiration_policy=TimeToIdle(timedelta(days=30))) |
Contributor
Author
There was a problem hiding this comment.
only made this change bcuz bugbot suggested it but not sure if we should, defer to objectstore folks
matt-codecov
approved these changes
May 19, 2026
Contributor
matt-codecov
left a comment
matt-codecov
left a comment
There was a problem hiding this comment.
lgtm, don't know why tests fail
Switch the objectstore expiration policy from TimeToLive to TimeToIdle so that snapshots that are still being accessed are not expired after a fixed 30-day window. Co-Authored-By: Claude <noreply@anthropic.com>
The previous commit updated the upload options endpoint to return TimeToIdle but missed the server-side _PREPROD_USECASE definition, creating a mismatch between client-facing and server-enforced expiration policy. Co-Authored-By: Claude <noreply@anthropic.com>
Update test to expect tti: prefix after TimeToLive → TimeToIdle rename. Add comment explaining that TTI intentionally resets on fetch so actively viewed snapshots do not silently expire. Co-Authored-By: Claude <noreply@anthropic.com>
NicoHinderling
force-pushed
the
ref/preprod-time-to-idle
branch
from
892155e to
8ba38cf
Compare
Contributor
|
PR reverted: ac9acca |
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
…ion (#115837) Switch the objectstore expiration policy from `TimeToLive` to `TimeToIdle` so that preprod snapshots that are still being accessed are not expired after a fixed 30-day window. With `TimeToIdle`, the expiration timer resets on each access, keeping actively-used snapshots alive. --------- Co-authored-by: Claude <noreply@anthropic.com>
NicoHinderling
added a commit
that referenced
this pull request
May 21, 2026
…ion (#116033) Switch the objectstore expiration policy from `TimeToLive` to `TimeToIdle` so that preprod snapshots that are still being accessed are not expired after a fixed 30-day window. With `TimeToIdle`, the expiration timer resets on each access, keeping actively-used snapshots alive. This was previously landed in #115837 and reverted. Re-landing with both the server-side `_PREPROD_USECASE` and the client-facing upload options endpoint using `TimeToIdle` consistently. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the objectstore expiration policy from
TimeToLivetoTimeToIdleso that preprod snapshots that are still being accessed are not expired
after a fixed 30-day window. With
TimeToIdle, the expiration timer resetson each access, keeping actively-used snapshots alive.