fix(seer): Keep repo loading indicator active#115854
Conversation
The repo table auto-fetches every page, but the spinner was tied to the individual page request state. That can briefly drop between cursors and make the loading indicator restart. Use a combined loading flag while more pages remain so the indicator stays mounted through the full fetch loop. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f223082. Configure here.
| </InputGroup> | ||
|
|
||
| {isFetchingNextPage ? <LoadingIndicator mini /> : null} | ||
| {isFetchingAllPages ? <LoadingIndicator mini /> : null} |
There was a problem hiding this comment.
Spinner persists after page error
Low Severity
After a failed fetchNextPage, hasNextPage can stay true while isFetchingNextPage is false. isFetchingAllPages then keeps the toolbar mini LoadingIndicator mounted even though the table body shows LoadingError and no further pages are being requested.
Reviewed by Cursor Bugbot for commit f223082. Configure here.
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
The continuous loading flag should only stay active while pagination can keep making progress. If a page fetch fails, stop treating hasNextPage as loading so the toolbar spinner does not persist next to the error state. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
| isPending, | ||
| isFetchingNextPage, | ||
| } = result; | ||
| const isFetchingAllPages = !isError && (hasNextPage || isFetchingNextPage); |
There was a problem hiding this comment.
ya, this is the pair of things to check every time
The repo table auto-fetches every page, but the spinner was tied to each individual page request. That made it briefly unmount between cursors and restart. Use a combined flag while more pages remain so the loading indicator stays mounted through the full fetch loop. [example page](https://sentry.sentry.io/settings/seer/repos/)
2 participants
The repo table auto-fetches every page, but the spinner was tied to each individual page request. That made it briefly unmount between cursors and restart.
Use a combined flag while more pages remain so the loading indicator stays mounted through the full fetch loop.
example page