Skip to content

perf(sdk): Add regex pattern support to traces sampler route matching #115874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obostjancic merged 2 commits into from
May 20, 2026
+13 −2
Merged

perf(sdk): Add regex pattern support to traces sampler route matching #115874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c80ebe
perf(sdk): Add regex pattern support to SAMPLED_ROUTES and sample ai-…
obostjancic May 20, 2026
9cdf40b
Merge branch 'master' into ogi/ai-conversations-sampled-route-pattern
obostjancic May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/sentry/utils/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import asyncio
import copy
import logging
import re
import sys
import typing
from collections.abc import Generator, Mapping, Sequence, Sized
Expand Down Expand Up @@ -92,6 +93,12 @@
"/api/0/auth/validate/": 0.0,
}

# List of (compiled_pattern, sample_rate) tried in order when no exact route matches.
SAMPLED_ROUTE_PATTERNS: list[tuple[re.Pattern[str], float]] = [
# Temporary: monitoring AI Conversations rollout
(re.compile(r"^/api/0/organizations/[^/]+/ai-conversations/"), 1.0),
]

if settings.ADDITIONAL_SAMPLED_TASKS:
SAMPLED_TASKS.update(settings.ADDITIONAL_SAMPLED_TASKS)

Expand Down Expand Up @@ -182,8 +189,12 @@ def get_project_key():

def traces_sampler(sampling_context):
wsgi_path = sampling_context.get("wsgi_environ", {}).get("PATH_INFO")
if wsgi_path and wsgi_path in SAMPLED_ROUTES:
return SAMPLED_ROUTES[wsgi_path]
if wsgi_path:
if wsgi_path in SAMPLED_ROUTES:
return SAMPLED_ROUTES[wsgi_path]
for pattern, rate in SAMPLED_ROUTE_PATTERNS:
if pattern.search(wsgi_path):
return rate

# Apply sample_rate from custom_sampling_context
custom_sample_rate = sampling_context.get("sample_rate")
Expand Down
Loading