perf(sdk): Use Django URL resolution for view-based trace sampling#115878
Draft
vgrozdanic wants to merge 1 commit into
Draft
perf(sdk): Use Django URL resolution for view-based trace sampling#115878vgrozdanic wants to merge 1 commit into
vgrozdanic wants to merge 1 commit into
Conversation
Add SAMPLED_VIEWS dict keyed by Django URL name, replacing the regex pattern approach with resolve()-based lookups. This avoids duplicating URL regexes and gives O(1) dict lookup instead of linear regex scans. Samples AI Conversations endpoints at 100% for rollout monitoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative to #115874. Instead of maintaining a parallel list of compiled regexes that duplicate URL patterns from
urls.py, this uses Django'sresolve()to match the request path against the existing URL conf and then looks up the resolved URL name in aSAMPLED_VIEWSdict.urls.py, so they can't drift out of syncSAMPLED_ROUTESis checked first, thenSAMPLED_VIEWSvia resolve, then the rest of the sampler logicSamples AI Conversations endpoints at 100% for rollout monitoring.
Routes covered