ref(ourlogs): remove expanded and window virtualizer from LogsInfiniteTable#115884
Conversation
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 47cce80. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JoshuaKGoldberg
changed the title
expanded and window virtualizer from LogsInfiniteTable
| : ` | ||
| overflow-y: auto; | ||
| height: 100%; | ||
| `} |
There was a problem hiding this comment.
[Explanation] I think this was for an overflow edge case that no longer gets hit in the constrained page layouts.
| ~ footer { | ||
| display: none; | ||
| } | ||
| `; |
There was a problem hiding this comment.
[Explanation] ViewportConstrainedPage hides the footer too. Switching to using it also makes this logs view no longer expand way beyond the viewport size when there are many logs.
Example URL: /explore/traces/trace/6f0c32cb007c4ac5926eb55cfd5bb046/?node=span-85ed9a74e889ad49&tab=logs
2 participants
Prior to this area of work,
LogsInfiniteTablecould use either a contained virtualizer (non-expanded mode) or window virtualizer (expanded mode). Now that we're always constrained to the page, I suspect we can stick with just contained.Trying this out, it seems to work effectively the same. Which I think makes sense: that the table is now always constrained to a parent element & size.
As a part of this, I also removed the
expandedprop. All but one uses of the table were using it, and it didn't do much else beyond changing theoverscanamount.Closes LOGS-813.