Skip to content

fix(replays): disable breadcrumbs autoscroll on user scroll#115914

Merged
JoshuaKGoldberg merged 1 commit into
masterfrom
replay-disable-auto-scroll-on-user-scroll
May 21, 2026
Merged

fix(replays): disable breadcrumbs autoscroll on user scroll#115914
JoshuaKGoldberg merged 1 commit into
masterfrom
replay-disable-auto-scroll-on-user-scroll

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 20, 2026

Switches the Replay auto-scroll feature off after the user scrolls themselves. It's turned back on if they press a 'Jump to current timestamp' button.

There's probably a more design-y way to do this (e.g. an 'autoscroll enabled' checkbox), but that'll have to be a separate followup.

Closes REPLAY-854.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 20, 2026

REPLAY-854

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.57%

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the replay-disable-auto-scroll-on-user-scroll branch from 8861ad2 to b1d0d0e Compare May 20, 2026 18:02
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 20, 2026 18:10
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner May 20, 2026 18:10
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b1d0d0e. Configure here.

Comment thread static/app/views/explore/replays/detail/breadcrumbs/index.tsx
Comment thread static/app/views/explore/replays/detail/breadcrumbs/index.tsx
Copy link
Copy Markdown
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I'm wondering if there should be more interactions that enable autoscroll, for example scrolling to the latest message, or maybe a just a toggle. Sounds like design could pitch in, but this PR is a good improvement

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(replays): disable autoscroll on user scroll fix(replays): disable breadcrumbs autoscroll on user scroll May 21, 2026
@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

Thanks! For sure. I filed REPLAY-918 to track doing a more complete something.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d178ffe into master May 21, 2026
73 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-disable-auto-scroll-on-user-scroll branch May 21, 2026 17:00
JonasBa pushed a commit that referenced this pull request May 21, 2026
Switches the Replay auto-scroll feature off after the user scrolls
themselves. It's turned back on if they press a 'Jump to current
timestamp' button.

There's probably a more design-y way to do this (e.g. an 'autoscroll
enabled' checkbox), but that'll have to be a separate followup.

Closes REPLAY-854.
natemoo-re pushed a commit that referenced this pull request May 21, 2026
Switches the Replay auto-scroll feature off after the user scrolls
themselves. It's turned back on if they press a 'Jump to current
timestamp' button.

There's probably a more design-y way to do this (e.g. an 'autoscroll
enabled' checkbox), but that'll have to be a separate followup.

Closes REPLAY-854.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants