feat(scm): Add streaming integration-proxy which accepts any 'Accepts' header value#115917
Conversation
github-actions
Bot
added
the
Scope: Backend
github-actions
Bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…github.com/getsentry/sentry into cmanallen/integration-proxy-accept-headers
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0baf0ef. Configure here.
| re_path( | ||
| # If modifying, ensure PROXY_BASE_PATH is updated as well | ||
| r"^integration-proxy2/$", | ||
| InternalIntegrationProxy2Endpoint.as_view(), | ||
| name="sentry-api-0-internal-integration-proxy2", | ||
| ), |
There was a problem hiding this comment.
Are we keeping both around indefinitely?
There was a problem hiding this comment.
@markstory No. They'll be merged. It's easier to test a parallel implementation, I think, than to re-write the integration-proxy endpoint.
…' header value (#115917) Currently the `integration-proxy` endpoint can only accept `application/json` and `*/*` `Accepts` headers. This change allows any `Accepts` header. Additionally the `integration-proxy2` endpoint streams the response to the connected proxy client. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
3 participants
Currently the
integration-proxyendpoint can only acceptapplication/jsonand*/*Acceptsheaders. This change allows anyAcceptsheader. Additionally theintegration-proxy2endpoint streams the response to the connected proxy client.