fix(tracemetrics): Pass project and env in request filters for filter#115920
Merged
narsaynorath merged 2 commits intoMay 20, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
nsdeschenes
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e60a103. Configure here.
narsaynorath
deleted the
nar/fix/tracemetrics-detectors-filter-bar-should-pass-project-environment-filters
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
…#115920) If we don't pass these along explicitly from the form state, `usePageFilters` gives us the locally stored values which can cause conflicts if it doesn't match the selection. To repro a problem scenario: - go to an org - select a project A from any of the page filters dropdowns - go to monitors and create a metric alert for application metrics - open devtools and select the network tab - change the project to some project B - change the metric to something in project B A request for attributes will be made, but it will have the project A ID in it, which conflicts with the metric since it's part of project B I debated _not_ passing down environment and only project, but since the metric selector already does both maybe it makes sense for us to pass them both along. I can remove them if we decide we just want the user to see everything in that project
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't pass these along explicitly from the form state,
usePageFiltersgives us the locally stored values which can cause conflicts if it doesn't match the selection.To repro a problem scenario:
A request for attributes will be made, but it will have the project A ID in it, which conflicts with the metric since it's part of project B
I debated not passing down environment and only project, but since the metric selector already does both maybe it makes sense for us to pass them both along. I can remove them if we decide we just want the user to see everything in that project