fix(preprod): Remove native lazy loading from LazyImage component#115922
Merged
NicoHinderling merged 1 commit intoMay 20, 2026
Conversation
The LazyImage component already manages its own visibility with loaded state and opacity:0 positioning. Stacking the browser's native loading="lazy" on top caused images to never trigger their load event in scrollable containers, leaving base images blank. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
mtopo27
approved these changes
May 20, 2026
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
…15922) Remove `loading="lazy"` and `decoding="async"` from the `LazyImage` component in the snapshot diff view. `LazyImage` already manages its own visibility via `loaded` state and `opacity: 0` positioning — it renders the `<img>` immediately but hides it until `onLoad` fires. Stacking the browser's native `loading="lazy"` on top caused the browser to defer fetching images it considered off-screen (inside scrollable containers with `opacity: 0`), so the `onLoad` event never fired and base images stayed blank. Introduced in #115836. Co-authored-by: Claude <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
loading="lazy"anddecoding="async"from theLazyImagecomponentin the snapshot diff view.
LazyImagealready manages its own visibility vialoadedstate andopacity: 0positioning — it renders the<img>immediately but hides ituntil
onLoadfires. Stacking the browser's nativeloading="lazy"on topcaused the browser to defer fetching images it considered off-screen (inside
scrollable containers with
opacity: 0), so theonLoadevent never firedand base images stayed blank.
Introduced in #115836.