fix(alerts): Update migration to not remove FK to group#115932
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
wedamija
reviewed
May 20, 2026
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
The sql needs to look like
ALTER TABLE "sentry_notificationmessage" ADD CONSTRAINT "sentry_notificationmessage_group_id_6e588d2d_notnull" CHECK ("group_id" IS NOT NULL) NOT VALID;
ALTER TABLE "sentry_notificationmessage" VALIDATE CONSTRAINT "sentry_notificationmessage_group_id_6e588d2d_notnull";
ALTER TABLE "sentry_notificationmessage" ALTER COLUMN "group_id" SET NOT NULL;
ALTER TABLE "sentry_notificationmessage" DROP CONSTRAINT "sentry_notificationmessage_group_id_6e588d2d_notnull";
Just from the generated sql here: #115578
Using the constraint this way allows us to not have to lock the table while we validate the data
wedamija
approved these changes
May 20, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
wedamija
approved these changes
May 20, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 076e050. Configure here.
wedamija
reviewed
May 20, 2026
Comment on lines
+44
to
+49
| DO $$ | ||
| BEGIN | ||
| ALTER TABLE "sentry_notificationmessage" ADD CONSTRAINT "sentry_notificationmessage_group_id_notnull" CHECK ("group_id" IS NOT NULL) NOT VALID; | ||
| EXCEPTION | ||
| WHEN duplicate_object THEN NULL; | ||
| END $$; |
Member
There was a problem hiding this comment.
Could also do DROP CONSTRAINT IF EXISTS before it. I think what you have will work, although I'm not sure if this is starting a transaction or something that might cause it to fail
wedamija
approved these changes
May 20, 2026
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
This migration fails when applying due to a timeout because it can't get a lock on the group column - the default generated migration when making a column nullable has Django drop and re-create the foreign key, so the fix (hopefully) is to add a `SeparateDatabaseAndState` to not do the unnecessary extra step of removing the FK first.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration fails when applying due to a timeout because it can't get a lock on the group column - the default generated migration when making a column nullable has Django drop and re-create the foreign key, so the fix (hopefully) is to add a
SeparateDatabaseAndStateto not do the unnecessary extra step of removing the FK first.