ref(forms): Migrate RequestIntegrationModal to TanStack form system#115990
Merged
priscilawebdev merged 7 commits intoMay 28, 2026
Merged
Conversation
Replace the legacy Form/TextareaField + local useState with useScrapsForm and field.TextArea, so the modal participates in the new form pipeline (validation, submitting state, SubmitButton busy/disabled handling). The mutation now receives the message via the form value instead of via closure on local state, and the submit button is driven by the form rather than a standalone Button click. Refs DE-1246 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
…-integration-modal-form-2
Use Flex gap for uniform spacing between Body children, replace TextBlock with Text, and drop the unused Message label on the textarea to match the pre-migration UX.
Replace legacy api.requestPromise with fetchMutation (the standard mutationFn for TanStack mutations) and remove density="comfortable" from the body Text paragraphs in favor of the default line-height.
The textarea placeholder already says "Optional message…", so the prefix on the surrounding paragraph is duplicative.
Use Stack instead of Flex with explicit column direction, inline the endpoint string at the call site, and destructure props in the function signature.
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5f43f95. Configure here.
…-integration-modal-form-2
TkDodo
approved these changes
May 28, 2026
priscilawebdev
deleted the
priscilawebdev/ref/de-1246-migrate-request-integration-modal-form-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/DE-1246/migrate