fix(tabs): stop tooltips in overflowMenuItems from crashing the page

[TkDodo]

This is a tricky one that I stumbled upon while fixing any types with no-unsafe-member-access. TypeScript didn’t catch this because item.props comes directly from react-aria and is hardcoded to any which is really bad.

Basically, TabList.Item allows passing in tooltips as tooltipProps, so we can do:

<TabList.Item tooltip={{ title: 'hello '}}>

This renders the tooltip on the TabItem fine, however when we have many tabs, the overflowing ones are rendered into a MenuItemList, which has a different type for the tooltip prop:

sentry/static/app/components/core/menuListItem/menuListItem.tsx

Lines 205 to 214 in f9bda05

	/**
	* Optional tooltip that appears when the use hovers over the item. This is
	* not very visible - if possible, add additional text via the `details`
	* prop instead.
	*/
	tooltip?: ExtraContent;
	/**
	* Additional props to be passed into <Tooltip />.
	*/
	tooltipOptions?: Omit<TooltipProps, 'children' | 'title' | 'className'>;

Basically tooltip is a ReactNode or a function that produces a ReactNode, and tooltipOptions are separate.

So what happens at runtime is that we pass tooltip={{ title: 'hello '}} to the MenuitemList, which renders it as-is because it's not a function, which makes react crash the page because it cannot render objects.

---

This fix is a hotfix at best to prevent this from happening. I think a proper fix would consolidate how we pass tooltips around: Do we just want tooltip to be the props object everywhere? The extra options are a weird API. However, the functional syntax to produce a tooltip doesn’t go well with extra options in one object. Best I could come up with is:

tooltip: Omit<TooltipProps, 'title'> & { title: ReactNode | (state) => ReactNode) }

This would be doable in a follow-up but has a larger surface area, would disallow passing string tooltips (which we do a lot, would need to change to {title: 'hello'} and with react-select and react-aria being any it's pretty hard to figure out where we produce options

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1e14f02. Configure here.}

[github-actions]

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.60%

[natemoo-re]

Slightly difficult to trace this change through, but your logic seems sound and the changes look straightforward enough!