fix(tracemetrics): Drop placeholder unit and always use none#116007
Merged
narsaynorath merged 7 commits intoMay 21, 2026
Merged
fix(tracemetrics): Drop placeholder unit and always use none#116007narsaynorath merged 7 commits into
narsaynorath merged 7 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.60% |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
narsaynorath
changed the title
nsdeschenes
reviewed
May 21, 2026
Contributor
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
Worth taking a peek at those cursor comments 👀
But from my review, things are looking good 👍
Member
Author
|
@cursor review (previous comment might be stale) |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 77c2c86. Configure here.
nsdeschenes
approved these changes
May 21, 2026
narsaynorath
deleted the
nar/fix/tracemetrics-drop-placeholder-type-and-treat-none
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
Since we don't want to use `-` anymore as a placeholder, we should really be coercing any `null` values to the string `"none"`, which adds special filters in both the frontend and backend code. This PR removes all fallbacks to `-` so we can just continue passing `"none"` along in the future. Anything that's saved also gets coerced to `"none"` when editing, which is the behaviour we want moving forward. I also de-duplicate selector options so the edge case when a metric name and type return with `null` and `"none"` units simultaneously get treated as the same value. All of the tests are also updated to drop using `-` and use `"none"`. There's a test added that shows stuff that still uses `-` gets changed into `"none"`
natemoo-re
pushed a commit
that referenced
this pull request
May 21, 2026
Since we don't want to use `-` anymore as a placeholder, we should really be coercing any `null` values to the string `"none"`, which adds special filters in both the frontend and backend code. This PR removes all fallbacks to `-` so we can just continue passing `"none"` along in the future. Anything that's saved also gets coerced to `"none"` when editing, which is the behaviour we want moving forward. I also de-duplicate selector options so the edge case when a metric name and type return with `null` and `"none"` units simultaneously get treated as the same value. All of the tests are also updated to drop using `-` and use `"none"`. There's a test added that shows stuff that still uses `-` gets changed into `"none"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't want to use
-anymore as a placeholder, we should really be coercing anynullvalues to the string"none", which adds special filters in both the frontend and backend code.This PR removes all fallbacks to
-so we can just continue passing"none"along in the future. Anything that's saved also gets coerced to"none"when editing, which is the behaviour we want moving forward.I also de-duplicate selector options so the edge case when a metric name and type return with
nulland"none"units simultaneously get treated as the same value.All of the tests are also updated to drop using
-and use"none". There's a test added that shows stuff that still uses-gets changed into"none"