feat(spans): Add separate Redis cluster setting for span deduplication#116010
Merged
untitaker merged 3 commits intoMay 21, 2026
Merged
Conversation
Add SENTRY_SPAN_DEDUPE_CLUSTER to allow span deduplication keys to be configured independently from the main span buffer cluster. This enables better resource isolation for dedupe operations. The setting defaults to SENTRY_SPAN_BUFFER_CLUSTER if not explicitly set, maintaining backwards compatibility. ref STREAM-1028
github-actions
Bot
added
the
Scope: Backend
ref STREAM-1028
lvthanh03
approved these changes
May 21, 2026
The RedisCluster type is not subscriptable at runtime in the installed version, so we need PEP 563 deferred evaluation. ref STREAM-1028
untitaker
deleted the
markusunterwaditzer/stream-1028-separate-span-dedupe-keys
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
#116010) ## Summary - Add `SENTRY_SPAN_DEDUPE_CLUSTER` setting to allow span deduplication keys to be configured independently from the main span buffer cluster - Defaults to `SENTRY_SPAN_BUFFER_CLUSTER` if not explicitly set, maintaining backwards compatibility - Enables better resource isolation for dedupe operations in the process_segments consumer Note: Flush locks remain on `SENTRY_SPAN_BUFFER_CLUSTER` because `add-buffer.lua` checks lock existence atomically during span ingestion. ref STREAM-1028
natemoo-re
pushed a commit
that referenced
this pull request
May 21, 2026
#116010) ## Summary - Add `SENTRY_SPAN_DEDUPE_CLUSTER` setting to allow span deduplication keys to be configured independently from the main span buffer cluster - Defaults to `SENTRY_SPAN_BUFFER_CLUSTER` if not explicitly set, maintaining backwards compatibility - Enables better resource isolation for dedupe operations in the process_segments consumer Note: Flush locks remain on `SENTRY_SPAN_BUFFER_CLUSTER` because `add-buffer.lua` checks lock existence atomically during span ingestion. ref STREAM-1028
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SENTRY_SPAN_DEDUPE_CLUSTERsetting to allow span deduplication keys to be configured independently from the main span buffer clusterSENTRY_SPAN_BUFFER_CLUSTERif not explicitly set, maintaining backwards compatibilityNote: Flush locks remain on
SENTRY_SPAN_BUFFER_CLUSTERbecauseadd-buffer.luachecks lock existence atomically during span ingestion.ref STREAM-1028