Skip to content

fix(ci): Dont pull the jest-balancer list when we run Just with merge_base_strategy=changedSince#116012

Draft
ryan953 wants to merge 1 commit into
masterfrom
ryan953/ci-jest-changedSince-no-balancer
Draft

fix(ci): Dont pull the jest-balancer list when we run Just with merge_base_strategy=changedSince#116012
ryan953 wants to merge 1 commit into
masterfrom
ryan953/ci-jest-changedSince-no-balancer

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented May 21, 2026

The problem i was seeing is that runtime under changedSince is the same as normal.

Here's an example run: https://github.com/getsentry/sentry/actions/runs/26233670488/job/77200730906

Run MERGE_BASE=$(git merge-base HEAD^1 HEAD^2 2>/dev/null) || true
Non-frontend file changed — running full Jest suite

And notice the 8 jest runners still take 3-4mins each:
https://github.com/getsentry/sentry/actions/runs/26233670488

I believe that the runners are basically ignoring the --changedSince arg and running the full list of tests that they find from the balance list.

If we skip downloading the balance list, then we'll save 3s on the job. but as of now there's still 8 runners which will all be doing the same list of tests... oops.
We might also want to add a label that skips all this and re-runs everything, ignoring the changedSince check.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.60%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant