fix(ci): Dont pull the jest-balancer list when we run Just with merge_base_strategy=changedSince#116012
Draft
ryan953 wants to merge 1 commit into
Draft
fix(ci): Dont pull the jest-balancer list when we run Just with merge_base_strategy=changedSince#116012ryan953 wants to merge 1 commit into
ryan953 wants to merge 1 commit into
Conversation
…_base_strategy=changedSince
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.60% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem i was seeing is that runtime under
changedSinceis the same as normal.Here's an example run: https://github.com/getsentry/sentry/actions/runs/26233670488/job/77200730906
And notice the 8 jest runners still take 3-4mins each:
https://github.com/getsentry/sentry/actions/runs/26233670488
I believe that the runners are basically ignoring the
--changedSincearg and running the full list of tests that they find from the balance list.If we skip downloading the balance list, then we'll save 3s on the job. but as of now there's still 8 runners which will all be doing the same list of tests... oops.
We might also want to add a label that skips all this and re-runs everything, ignoring the changedSince check.