fix(relay): Make trustedRelays optional on Organization type#116014
Merged
TkDodo merged 1 commit intoMay 21, 2026
Merged
Conversation
The OrganizationSummarySerializer (used when detailed=0 and the user lacks org:read) does not include trustedRelays, but the TypeScript type declared it as required. This mismatch caused a runtime crash when accessing trustedRelays.length on the Relay settings page. Mark trustedRelays as optional on the Organization type and add nullish coalescing fallbacks in the relay wrapper component. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.60% |
JonasBa
approved these changes
May 21, 2026
TkDodo
deleted the
tkdodo/fix/de-1265-typeerror-cannot-read-properties-of-undefined-reading-length
branch
natemoo-re
pushed a commit
that referenced
this pull request
May 21, 2026
The `Organization` TypeScript type declared `trustedRelays` as a required `Relay[]`, but the backend's `OrganizationSummarySerializer` (used when `detailed=0` and the user lacks `org:read`) does not include this field. This caused a runtime crash (`Cannot read properties of undefined (reading 'length')`) on the Relay settings page. Mark `trustedRelays` as optional on the `Organization` type and add nullish coalescing fallbacks in the relay wrapper component. fixes JAVASCRIPT-39V9 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OrganizationTypeScript type declaredtrustedRelaysas a requiredRelay[], but the backend'sOrganizationSummarySerializer(used whendetailed=0and the user lacksorg:read) does not include this field. This caused a runtime crash (Cannot read properties of undefined (reading 'length')) on the Relay settings page.Mark
trustedRelaysas optional on theOrganizationtype and add nullish coalescing fallbacks in the relay wrapper component.fixes JAVASCRIPT-39V9