ref(snapshots): Use selective upload and filter to DiffImageDisplay only#116034
Draft
NicoHinderling wants to merge 5 commits into
Draft
ref(snapshots): Use selective upload and filter to DiffImageDisplay only#116034NicoHinderling wants to merge 5 commits into
NicoHinderling wants to merge 5 commits into
Conversation
Test selective snapshot upload by filtering Jest to only run DiffImageDisplay snapshot tests and passing --selective to sentry-cli. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Change headLabel default from 'Head' to 'Latest' in DiffImageDisplay to trigger a visual diff in snapshot tests. Also create the snapshot output directory if it doesn't exist before uploading. Co-Authored-By: Claude <noreply@anthropic.com>
pnpm run snapshots -- forwards args after a bare --, which Jest interprets as positional args rather than flags. Call jest directly via pnpm exec instead. Co-Authored-By: Claude <noreply@anthropic.com>
Cache the Playwright Chromium binary keyed by Playwright version. Split browser download and system deps install so that on cache hit only the fast apt-based deps step runs. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.62% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test selective snapshot upload by filtering the Jest snapshot run to only
generate DiffImageDisplay snapshots, and passing
--selectivetosentry-cli build snapshotsfor the upload step.This is a test to verify the selective upload workflow works correctly
before rolling it out more broadly.