chore(relocations) Add bucket_path to RelocationFile#116035
Merged
Merged
Conversation
Currently we move relocation blobs around between cells via RPC. This isn't working out so well and we want to move to a shared bucket based design. When customers upload dumps (or when we generate on for saas relocation) we create `RelocationFile` instances and `File` blobs. While the shared bucket design avoids needing to move blobs around, and file names can be derived from the relocation.uuid, we still need `RelocationFile` to handle retries. Currently when a relocation is performed, the `RelocationFile` metadata is copied onto the new relocation. Without `bucket_path` we won't have a a way for a retry to find the original dump file (as its path references the old uuid). Refs INFRENG-318
github-actions
Bot
added
the
Scope: Backend
GabeVillalobos
approved these changes
May 21, 2026
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Add field bucket_path to relocationfile
--
ALTER TABLE "sentry_relocationfile" ADD COLUMN "bucket_path" varchar NULL; |
wedamija
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we move relocation blobs around between cells via RPC. This isn't working out so well and we want to move to a shared bucket based design.
When customers upload dumps (or when we generate on for saas relocation) we create
RelocationFileinstances andFileblobs. While the shared bucket design avoids needing to move blobs around, and file names can be derived from the relocation.uuid, we still needRelocationFileto handle retries. Currently when a relocation is performed, theRelocationFilemetadata is copied onto the new relocation. Withoutbucket_pathwe won't have a a way for a retry to find the original dump file (as its path references the old uuid).Refs INFRENG-318