fix(silo): Reduce timeout and disable retries for synchronous proxy requests#116043
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(silo): Reduce timeout and disable retries for synchronous proxy requests#116043sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Co-authored-by: sentry-warden[bot] <258096371+sentry-warden[bot]@users.noreply.github.com>
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a "Blocking Operation" performance issue (SENTRY-5PX9) observed on the
/api/0/organizations/{organization_id_or_slug}/issues/endpoint.Problem:
The
ratelimit.__call__middleware was blocking for ~2.4 seconds due to a synchronous HTTP call made byCellSiloClient.proxy_request()to an internal Cell Silo endpoint. This blocking was exacerbated by a long default timeout and inappropriate retry logic for synchronous proxy operations.Changes:
CellSiloClienttimeout: The defaulttimeoutforCellSiloClienthas been reduced from 30 seconds to 10 seconds. This prevents a single unresponsive Cell Silo from blocking a Control Silo request thread for an excessively long duration.proxy_request: Theproxy_requestmethod now explicitly disables retries before making thesuper()._request()call. Synchronous proxy requests within a Django request cycle should fail fast rather than retrying with backoff, which would compound the blocking time and worsen user experience.These changes ensure that synchronous cross-silo proxy calls are more resilient to slow Cell Silo responses and do not excessively block the Control Silo's request processing.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5PX9