feat(tracemetrics): Convert equation alias to full equation for queries#116047
Merged
narsaynorath merged 9 commits intoMay 25, 2026
Merged
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c03cb74. Configure here.
DominikB2014
approved these changes
May 25, 2026
Contributor
DominikB2014
left a comment
There was a problem hiding this comment.
lgtm! just small nit to use a utility function for dealing with sorts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The RPC endpoint for tracemetrics doesn't take
equation[0]as a valid sort and expects the fullequation|...format. This PR ensures that when we make requests to the datasets with sorts (e.g. grouped series, or categorical bar charts) that the full equation is used.This is done by updating two surfaces:
DiscoverDatasets.TRACEMETRICSsimilar to spans and logs, which use RPC and have the same constraints/handlingThis shouldn't require feature-flagging because it's gated on having the equation builder, which itself is feature flagged.
I did a bunch of this PR manually and guided with claude before I realized there was a lot simpler of an implementation where we can internally use the
equation[0]syntax for now and convert on the requests. At that point I prompted it to remove a bunch of the old cruft, rework the stuff that remained, and add tests.