Skip to content

feat(preprod): Display images_skipped in snapshot table#116074

Merged
NicoHinderling merged 1 commit into
masterfrom
feat/preprod-images-skipped-ui
May 22, 2026
Merged

feat(preprod): Display images_skipped in snapshot table#116074
NicoHinderling merged 1 commit into
masterfrom
feat/preprod-images-skipped-ui

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

@NicoHinderling NicoHinderling commented May 21, 2026

Wire images_skipped into the frontend ChangeCounts component so the snapshots table displays skipped image counts when present (e.g., "5 skipped").

Also fixes a bug in the "No changes" early return: previously, a selective snapshot run with 0 added/removed/changed but >0 skipped images would show "No changes" instead of "N skipped". The condition now checks skipped === 0 as well, matching the backend behavior in VCS status check templates.

Depends on #116073.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 21, 2026
Copy link
Copy Markdown
Contributor Author

NicoHinderling commented May 21, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.63%

@NicoHinderling NicoHinderling marked this pull request as ready for review May 22, 2026 00:21
@NicoHinderling NicoHinderling requested a review from a team as a code owner May 22, 2026 00:21
NicoHinderling added a commit that referenced this pull request May 22, 2026
Include the `images_skipped` count in the `snapshot_comparison_info`
returned by the builds endpoint. The field was already stored on the
`PreprodSnapshotComparison` DB model and computed in the snapshot diff
task but was omitted from the API response.

Part 1 of a stack — backend only. Frontend changes in #116074.

Co-authored-by: Claude <noreply@anthropic.com>
Base automatically changed from feat/preprod-images-skipped-api to master May 22, 2026 00:23
Wire images_skipped into the frontend ChangeCounts component so the
snapshots table displays skipped image counts when present. Also fix
the "No changes" early return to account for skipped-only cases,
matching the backend behavior.

Co-Authored-By: Claude <noreply@anthropic.com>
@NicoHinderling NicoHinderling force-pushed the feat/preprod-images-skipped-ui branch from 6bf7d3f to e8fe9ab Compare May 22, 2026 00:24
@NicoHinderling NicoHinderling merged commit cd7c5f1 into master May 22, 2026
72 checks passed
@NicoHinderling NicoHinderling deleted the feat/preprod-images-skipped-ui branch May 22, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants