ref(db): Add strong typing to postgres DatabaseWrapper#116088
Draft
vgrozdanic wants to merge 1 commit into
Draft
ref(db): Add strong typing to postgres DatabaseWrapper#116088vgrozdanic wants to merge 1 commit into
vgrozdanic wants to merge 1 commit into
Conversation
Add concrete type annotations to CursorWrapper and DatabaseWrapper in sentry.db.postgres.base, replacing untyped parameters with specific types from psycopg2 and Django stubs. Any is retained only where Django's execute_wrapper protocol or the proxy pattern requires it. Remove sentry.db.postgres.base from the mypy typing-issues ignore list. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add concrete type annotations to
CursorWrapperandDatabaseWrapperinsentry.db.postgres.base, replacing untyped parameters with specific typesfrom psycopg2 and Django stubs.
Anyis retained only where Django's_ExecuteWrapperprotocol or the__getattr__proxy pattern requires it. SQL params useSequence[object] | Mapping[str, object] | Noneinstead ofAny.Removes
sentry.db.postgres.basefrom the mypy typing-issues ignore list(the block that disables
arg-type,assignment,attr-defined, etc.).