fix(api): Hide internal trace attributes from discovery#116092
Closed
nsdeschenes wants to merge 2 commits into
Closed
fix(api): Hide internal trace attributes from discovery#116092nsdeschenes wants to merge 2 commits into
nsdeschenes wants to merge 2 commits into
Conversation
Add a shared helper for hiding internal Sentry convention attributes from API surfaces and let SearchResolver track attributes hidden by API visibility configuration. This keeps default resolver behavior unchanged unless an API caller opts into visibility enforcement.
Filter internal Sentry convention attributes from trace item and span attribute discovery APIs unless the requester is staff or superuser. Apply the same visibility checks to attribute value autocomplete and validation so hidden attributes are treated as unknown for regular users.
github-actions
Bot
added
the
Scope: Backend
Contributor
Author
|
Closing out in favour of a clean slate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
can_expose_attribute_to_api()filtering toOrganizationTraceItemAttributesEndpoint— internal attributes are excluded from attribute search, autocomplete, and aliased column listingsOrganizationSpansFieldsEndpointandEAPSpanFieldValuesAutocompletionExecutor— internal span fields and their values are hidden from non-staff usersinclude_internal=TrueDepends on #116091
Test plan
test_organization_trace_item_attributes.pyandtest_organization_spans_fields.pyverifying internal attributes are excluded from responsesCloses TODO