chore(autofix): Remove unused autofix v1 UI#116100
Merged
Merged
Conversation
This is no longer in use so time to remove it.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+71
to
+81
| <SecondaryNavigation.ListItem> | ||
| <SecondaryNavigation.Link | ||
| to={`${baseUrl}/autofix/recent/`} | ||
| analyticsItemName="issues_autofix" | ||
| end | ||
| > | ||
| {t('Recently Run')} | ||
| </SecondaryNavigation.Link> | ||
| </SecondaryNavigation.ListItem> | ||
| </SecondaryNavigation.List> | ||
| </SecondaryNavigation.Section> |
Contributor
There was a problem hiding this comment.
Bug: The "Autofix" navigation is now visible to all users, regardless of the autofix-on-explorer feature flag, exposing an incomplete feature to users who should not see it.
Severity: MEDIUM
Suggested Fix
Reinstate the feature flag check for the autofix-on-explorer feature. The visibility of the "Autofix" navigation item in issuesSecondaryNavigation.tsx and the command palette action in commandPaletteGlobalActions.tsx should be conditional on this flag being enabled for the user's organization.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
static/app/views/navigation/secondary/sections/issues/issuesSecondaryNavigation.tsx#L68-L81
Potential issue: The "Autofix" navigation section and its corresponding command palette
action are now displayed unconditionally to all users. Previously, this UI was gated by
the `autofix-on-explorer` feature flag. Users in organizations without this flag enabled
will now see the "Autofix > Recently Run" navigation item. Clicking it leads to a page
that queries for issues using `has:issue.seer_last_run`. While the backend correctly
adjusts the search field based on the feature flag's presence, the UI was intentionally
hidden for users without the flag. Exposing this navigation path is a functional
regression, as it leads users to an experimental or incomplete feature, potentially
resulting in a confusing experience with empty or unexpected results.
Also affects:
static/app/components/commandPalette/ui/commandPaletteGlobalActions.tsx:336~341
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer in use so time to remove it.