ref(mypy): Rename sort_stronger_modules to sort_weaklist#116106
Merged
Conversation
The new name matches the pre-commit hook id (sort-mypy-weaklist) and the rest of the weaklist tooling (check_stronglist, prevent_weaklist_additions). A re-export shim is kept at the old module path so getsentry's .pre-commit-config.yaml keeps working until it is updated to call the new name. Once getsentry is updated, a follow-up will remove the shim. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
the
Scope: Backend
armenzg
commented
May 22, 2026
|
|
||
| return ret | ||
|
|
||
| from tools.mypy_helpers.sort_weaklist import main |
Member
Author
There was a problem hiding this comment.
We will keep both scripts until getsentry is merged.
wedamija
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
tools.mypy_helpers.sort_stronger_modulestotools.mypy_helpers.sort_weaklistso the module name matches the pre-commit hook id (sort-mypy-weaklist) and the rest of the weaklist tooling (check_stronglist,prevent_weaklist_additions).Backwards-compatible shim
The old module path stays as a 4-line re-export so getsentry's
.pre-commit-config.yaml, which still callspython3 -m tools.mypy_helpers.sort_stronger_modules, keeps working. A follow-up PR will delete the shim once getsentry has been updated to callsort_weaklist.Made with Cursor