fix(cross-events): Correct styling based off date selection#116124
Merged
nsdeschenes merged 2 commits intoMay 25, 2026
Merged
Conversation
Constrain the metric selector and query builder columns so long content can shrink within the cross-event metric row.
Render cross-event rows in a separate grid when the date filter uses explicit start and end dates so the independent date controls align with each row.
github-actions
Bot
added
the
Scope: Frontend
Contributor
Author
|
@cursor review |
Contributor
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0250fc2. Configure here.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
Comment on lines
+192
to
+198
| {hasCrossEvents && !hasAbsoluteDateSelection ? ( | ||
| <SpansTabCrossEventSearchBars /> | ||
| ) : null} | ||
| </Grid> | ||
| {hasCrossEvents && hasAbsoluteDateSelection ? ( | ||
| <SpansTabCrossEventSearchBars hasIndependentDateColumn /> | ||
| ) : null} |
Member
There was a problem hiding this comment.
Suggested change
| {hasCrossEvents && !hasAbsoluteDateSelection ? ( | |
| <SpansTabCrossEventSearchBars /> | |
| ) : null} | |
| </Grid> | |
| {hasCrossEvents && hasAbsoluteDateSelection ? ( | |
| <SpansTabCrossEventSearchBars hasIndependentDateColumn /> | |
| ) : null} | |
| {hasCrossEvents ? ( | |
| <SpansTabCrossEventSearchBars hasIndependentDateColumn={hasAbsoluteDateSelection} /> | |
| ) : null} |
can we just do this?
Contributor
Author
There was a problem hiding this comment.
I tried that initially but things become unaligned and a little gross :/
nikkikapadia
approved these changes
May 25, 2026
nsdeschenes
deleted the
nd/fix-cross-events-fix-styling-based-off-date-selection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to tweak the styles for the cross-event query section based off of the period selection. There are a couple issues currently when selecting an exact date range so this PR tweaks the styles based off of that condition.