Skip to content

build(oxfmt): ignore pyproject.toml#116181

Merged
ryan953 merged 1 commit into
masterfrom
fix/oxfmt-ignore-pyproject-toml
May 26, 2026
Merged

build(oxfmt): ignore pyproject.toml#116181
ryan953 merged 1 commit into
masterfrom
fix/oxfmt-ignore-pyproject-toml

Conversation

@sentry-junior
Copy link
Copy Markdown
Contributor

@sentry-junior sentry-junior Bot commented May 26, 2026

oxfmt has TOML support and picks up pyproject.toml, which conflicts with Python tooling (prek/ruff) that owns that file. pnpm fix:format ends up reformatting it, then prek fights it back.

Adding pyproject.toml to ignorePatterns in .oxfmtrc.json keeps them from stepping on each other.

Action taken on behalf of Ryan Albrecht.


View Session in Sentry

oxfmt picks up pyproject.toml via TOML support, which conflicts with
Python tooling (prek/ruff) that owns that file. Add it to ignorePatterns
so pnpm fix:format and pnpm lint:format leave it alone.

Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
---
[View Session in Sentry](https://sentry.sentry.io/traces/?project=4510944073809921&query=gen_ai.conversation.id%3A%22slack%3AC8V02RHC7%3A1779803895.919769%22)
@ryan953 ryan953 marked this pull request as ready for review May 26, 2026 14:15
@ryan953 ryan953 requested a review from a team as a code owner May 26, 2026 14:15
@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 26, 2026
@ryan953 ryan953 merged commit ed7cb1a into master May 26, 2026
66 of 67 checks passed
@ryan953 ryan953 deleted the fix/oxfmt-ignore-pyproject-toml branch May 26, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant