fix(security): Add project-level access check to GroupEventJsonView#116184
Merged
roggenkemper merged 1 commit intoMay 26, 2026
Merged
Conversation
GroupEventJsonView only checked org-level event:read scope but not whether the user has access to the group's project. In orgs with closed membership, a user on team A could read raw event JSON (including PII) from a project owned by team B by guessing group IDs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
cvxluo
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupEventJsonViewchecked org-levelevent:readscope viaOrganizationViewbut did not verify the user has access to the resolved group's project. In orgs with closed membership (team-based access), a user on team A could read raw event JSON (PII, stacktraces, request bodies) from any project by guessing group IDs. Addedrequest.access.has_project_access(group.project)check after resolving the group, returning 404 on denial (consistent with the existing cross-org pattern)Fixes ID-1563