Skip to content

fix(security): Add project-level access check to GroupEventJsonView#116184

Merged
roggenkemper merged 1 commit into
masterfrom
roggenkemper/fix/group-event-json-project-access
May 26, 2026
Merged

fix(security): Add project-level access check to GroupEventJsonView#116184
roggenkemper merged 1 commit into
masterfrom
roggenkemper/fix/group-event-json-project-access

Conversation

@roggenkemper
Copy link
Copy Markdown
Member

@roggenkemper roggenkemper commented May 26, 2026

GroupEventJsonView checked org-level event:read scope via OrganizationView but did not verify the user has access to the resolved group's project. In orgs with closed membership (team-based access), a user on team A could read raw event JSON (PII, stacktraces, request bodies) from any project by guessing group IDs. Added request.access.has_project_access(group.project) check after resolving the group, returning 404 on denial (consistent with the existing cross-org pattern)

Fixes ID-1563

GroupEventJsonView only checked org-level event:read scope but not whether
the user has access to the group's project. In orgs with closed membership,
a user on team A could read raw event JSON (including PII) from a project
owned by team B by guessing group IDs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 26, 2026

ID-1563

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on ff3adfe in this run:

tests/sentry/migrations/test_1072_backfill_scm_integration_config.py::BackfillScmIntegrationConfigTest::testlog
Test passed but took too long to run: Duration 122.76700825500006s > 120.0s

@roggenkemper roggenkemper marked this pull request as ready for review May 26, 2026 15:54
@roggenkemper roggenkemper requested a review from a team as a code owner May 26, 2026 15:54
@roggenkemper roggenkemper requested a review from a team May 26, 2026 16:00
@roggenkemper roggenkemper merged commit 396de95 into master May 26, 2026
75 of 77 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/fix/group-event-json-project-access branch May 26, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants