fix(discover): Add missing check for DiscoverSavedQueryVisitEndpoint#116187
Merged
nsdeschenes merged 1 commit intoMay 26, 2026
Conversation
…sit endpoint DiscoverSavedQueryVisitEndpoint.post skipped check_object_permissions, allowing any org member with org:read to mutate visits and last_visited on saved queries scoped to projects they lack access to. The sibling GET/PUT/DELETE handlers all enforce this check. Fixes VULN-1691 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
adrianviquez
approved these changes
May 26, 2026
Contributor
adrianviquez
left a comment
adrianviquez
left a comment
There was a problem hiding this comment.
Mmmm, is this something that is required by other endpoints? I'm wondering how this could be prevented for the future, like adding it as a base permission or smth, though idk if this applies more broadly or case by case basis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in a missing check in the
DiscoverSavedQueryVisitEndpointendpoint.Closes BROWSE-518