Skip to content

fix(pageFilters): Sort bookmarked projects above non-member projects#116196

Merged
JonasBa merged 1 commit into
masterfrom
jb/pagefilters/selector
May 27, 2026
Merged

fix(pageFilters): Sort bookmarked projects above non-member projects#116196
JonasBa merged 1 commit into
masterfrom
jb/pagefilters/selector

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented May 26, 2026

Prioritize bookmarked projects over membership status in our project page filter sort

@JonasBa JonasBa requested a review from a team as a code owner May 26, 2026 15:55
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 26, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e18d0fb. Configure here.

Comment thread static/app/components/pageFilters/project/projectPageFilter.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.56%

Previously the project selector sorted by: selected > member > bookmarked.
This meant bookmarked non-member projects appeared below all member
projects, even unbookmarked ones. Swap the priority so bookmarking
ranks above membership: selected > bookmarked > member > alphabetical.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@JonasBa JonasBa force-pushed the jb/pagefilters/selector branch from e18d0fb to d701e8f Compare May 26, 2026 16:13
@JonasBa JonasBa changed the title fix(pageFilters): Derive bookmarked projects from store instead of stale useState initializer fix(pageFilters): Sort bookmarked projects above non-member projects May 26, 2026
@JonasBa JonasBa merged commit b21513d into master May 27, 2026
73 checks passed
@JonasBa JonasBa deleted the jb/pagefilters/selector branch May 27, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants