chore(typing): Remove tests.sentry.api.helpers.test_group_index from mypy ignore list#116199
Merged
shashjar merged 2 commits intoMay 26, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
armenzg
approved these changes
May 26, 2026
cvxluo
approved these changes
May 26, 2026
| self.assert_analytics_recorded(mock_record) | ||
|
|
||
|
|
||
| def _wrap_request(http_request: Any, data: dict[str, Any] | None = None) -> Request: |
Contributor
There was a problem hiding this comment.
curious on why we need this helper? seems like something that we would have a pattern for somewhere else in the codebase
Member
Author
There was a problem hiding this comment.
yea we do have drf_request_from_request but it doesn't handle setting data on the request - apparently that isn't a common pattern in our tests. so instead of adding an optional param there i went with just a local helper
shashjar
deleted the
shashjar/type-tests-sentry-api-helpers-test-group-index
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ENG-6460.
Fixes the
mypyerrors intests.sentry.api.helpers.test_group_index.