fix(explore): Use unique ids for visuals#116204
Merged
nsdeschenes merged 1 commit intoMay 26, 2026
Merged
Conversation
… after deletion When deleting a visualization from the middle of the list, index-based React keys caused component reuse mismatches. The ArithmeticBuilder's internal useState kept the deleted item's expression while the chart rendered the correct data, producing a visible desync. Use DragNDropContext's deleteColumnAtIndex (which properly maintains stable uniqueId refs) and key components by uniqueId instead of index. Closes EXP-960
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
narsaynorath
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves to using unique ids in
ToolbarVisualize, when rending in the DnD context. This PR also migrates handling of deletions to the built indeleteColumnAtIndexfunction.Closes EXP-960