Skip to content

chore(dashboards): remove text widget flag defintion#116212

Merged
nikkikapadia merged 2 commits into
masterfrom
nikki/remove-text-widget-flag-def
May 27, 2026
Merged

chore(dashboards): remove text widget flag defintion#116212
nikkikapadia merged 2 commits into
masterfrom
nikki/remove-text-widget-flag-def

Conversation

@nikkikapadia
Copy link
Copy Markdown
Member

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 26, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d7a5c76. Configure here.

manager.add("organizations:dashboards-prebuilt-insights-dashboards", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable the details widget for dashboards
manager.add("organizations:dashboards-details-widget", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable text widgets for dashboards
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing flag definition breaks text widget validation

High Severity

Removing the organizations:dashboards-text-widgets flag definition from temporary.py while the backend still gates on it in _validate_text_widget will break all text widget creation and editing. When features.has() is called for an unregistered flag, _get_feature_class raises FeatureNotRegistered, which is caught by the exception handler in has() and returns False. This causes the serializer to always reject text widgets with "Text widgets are not enabled". The frontend typeSelector.tsx also checks this flag and will hide the text widget option.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d7a5c76. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other prs remove it from the code

@nikkikapadia nikkikapadia marked this pull request as ready for review May 26, 2026 18:03
Comment thread src/sentry/features/temporary.py
@nikkikapadia nikkikapadia merged commit a1a1c16 into master May 27, 2026
115 of 117 checks passed
@nikkikapadia nikkikapadia deleted the nikki/remove-text-widget-flag-def branch May 27, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants