Skip to content

fix(tracemetrics): Use equation alias format for widget builder#116213

Merged
narsaynorath merged 2 commits into
masterfrom
nar/fix/tracemetrics-use-equation-alias-format-for-widget-builder
May 26, 2026
Merged

fix(tracemetrics): Use equation alias format for widget builder#116213
narsaynorath merged 2 commits into
masterfrom
nar/fix/tracemetrics-use-equation-alias-format-for-widget-builder

Conversation

@narsaynorath
Copy link
Copy Markdown
Member

@narsaynorath narsaynorath commented May 26, 2026

When passing the widget off from the Add to Dashboard preview to the widget builder, we need to convert the equation from the full raw form (because the raw form is used in the chart) to the equation alias format in widget builder because that's the way some of the UI expects it to be to make the correct selection

If not, then the UI renders a custom equation field which we do not support at this time for metrics widgets in dashboards

@narsaynorath narsaynorath requested review from a team as code owners May 26, 2026 17:58
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 26, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1d2f48a. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.56%

@narsaynorath narsaynorath merged commit 4085619 into master May 26, 2026
71 checks passed
@narsaynorath narsaynorath deleted the nar/fix/tracemetrics-use-equation-alias-format-for-widget-builder branch May 26, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants