fix(tracemetrics): Use equation alias format for widget builder#116213
Merged
narsaynorath merged 2 commits intoMay 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d2f48a. Configure here.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
nsdeschenes
approved these changes
May 26, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When passing the widget off from the Add to Dashboard preview to the widget builder, we need to convert the equation from the full raw form (because the raw form is used in the chart) to the equation alias format in widget builder because that's the way some of the UI expects it to be to make the correct selection
If not, then the UI renders a custom equation field which we do not support at this time for metrics widgets in dashboards