fix(profiling): render single-sample continuous profile chunks#116234
Merged
Conversation
Single-sample chunks have every sample diff against itself, giving weight=0, which appendSample discards — leaving 0 samples and showing "This flamegraph has no data." Assign a 10ms default weight (100Hz) so the stack is still visible. Also fix getMaxConfigSpace to use each profile's end position (startedAt offset + duration) rather than just duration, so a profile that starts late in the observability window isn't clipped off-screen.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4bbd5d9. Configure here.
nsdeschenes
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuous profile chunks with a single sample give weight 0 to that sample (it diffs against itself). That causes
appendSampleto discard it and show "This flamegraph has no data." This adds a 10ms default instead to match matching the 100Hz sampling rate so the stack is still visible.This also fixes
getMaxConfigSpaceto use each profile's end position (startedAt+duration) instead of justduration. Without this, a profile that starts late in the observability window renders its frames mostly off-screen, appearing blank even after the weight fix.Put together, this fixes rendering for the two main views reported in PRO-43.
Closes PRO-43.